Skip to content

fix(slack): validate webhook timestamps strictly - #925

Merged
ralyodio merged 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/slack-strict-webhook-timestamp
Aug 3, 2026
Merged

fix(slack): validate webhook timestamps strictly#925
ralyodio merged 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/slack-strict-webhook-timestamp

Conversation

@aiirvizionz

Copy link
Copy Markdown
Contributor

Summary

  • require Slack request signature timestamps to be decimal Unix-second integers
  • reject exponent, hexadecimal, fractional, signed, and whitespace-padded forms
  • reject values outside JavaScript safe-integer range before replay-window checks

Validation

  • vitest run packages/bots/slack/src/index.test.ts (10 tests passed)
  • tsc -p packages/bots/slack/tsconfig.json --noEmit
  • git diff --check

Copilot AI review requested due to automatic review settings August 1, 2026 21:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@ralyodio
ralyodio merged commit d1b13f1 into profullstack:master Aug 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants