ci: move actions off the deprecated Node 20 runtime - #951
Merged
Conversation
checkout, setup-node and pnpm/action-setup all still targeted Node 20, so every run was being forced onto Node 24 with a deprecation warning. pnpm/action-setup v6 refuses to start when a `version:` input and a `packageManager` field both name a pnpm version, so drop the redundant `version: 9.12.0` from test.yml and release.yml — package.json already pins pnpm@9.12.0 and stays the single source of truth.
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
ThreatCrush Security Scan323 finding(s) HIGH/CRITICAL: 23 | MEDIUM: 64 | LOW: 236
…and 273 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
setup-node v5 caches for the package.json `packageManager` by default. The scan job never installs pnpm, so that default made it fail with 'Unable to locate executable file: pnpm'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
releaserun flagged this:Bumps all three to majors that target Node 24 natively —
checkout@v5,setup-node@v5,action-setup@v6— across all five workflows.One thing that is not a straight version bump:
pnpm/action-setup@v6errors out when aversion:input and apackageManagerfield both name a pnpm version.test.ymlandrelease.ymlpassedversion: 9.12.0whilepackage.jsonalready pinspnpm@9.12.0, so the redundant inputs are removed andpackage.jsonstays the single source of truth.auto-rebase.ymlonly passesrun_install: falseand needed no change.Opened as a PR rather than pushed to
mastersotestvalidates the runner change before it lands.