chore: drop the .pyc that #963 committed, and ignore them - #964
Merged
Conversation
__pycache__/threatcrush-to-sarif.cpython-314.pyc went in with #963. Testing the converter means importing it, importing it writes bytecode beside it, and `git add -A` on that directory took the lot. No consumer saw it: the pack's `files:` list names workflow.yml and threatcrush-to-sarif.py explicitly, so nothing globs the directory and nothing shipped. This is repository hygiene, not an install problem. Ignored rather than only deleted, because the next person to run that converter locally will regenerate it and the same `git add -A` will pick it up again. One Python file in the repository is exactly the number that makes this easy to miss. Signed-off-by: Anthony Ettinger <anthony@chovy.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
ThreatCrush Security Scan311 finding(s) HIGH/CRITICAL: 24 | MEDIUM: 51 | LOW: 236
…and 261 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__pycache__/threatcrush-to-sarif.cpython-314.pycwent in with #963. My error: testing the converter means importing it, importing it writes bytecode beside it, andgit add -Aon that directory took the lot.No consumer saw it. The pack's
files:list namesworkflow.ymlandthreatcrush-to-sarif.pyexplicitly, so nothing globs the directory and nothing shipped to any target repo. This is repository hygiene, not an install problem.Ignored rather than only deleted, because the next person to run that converter locally will regenerate it and the same
git add -Awill pick it up again. One Python file in the repo is exactly the number that makes this easy to miss.🤖 Generated with Claude Code