sh1pt: install Node pnpm CI (node-pnpm-ci@1.2.0)#10
Merged
Conversation
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
The CI (ci.yml) and test (test.yml) workflows use `cache: pnpm` and `pnpm install --frozen-lockfile`, both of which require a committed pnpm-lock.yaml. The repo declared `packageManager: pnpm@10.6.5` but .gitignore excluded the lockfile, so the workflows failed at the setup-node step with "Dependencies lock file is not found". - Remove pnpm-lock.yaml from .gitignore - Commit the lockfile generated with pnpm 10.6.5 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The test suite is integration tests that shell out to ffmpeg/ffprobe and ImageMagick's `convert`. Without those binaries the tests fail with "FFmpeg is not installed or not available in PATH". Add an apt install step to both the CI and test workflows so the runner has them. Verified locally: 85 passing, 12 pending, 0 failing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sh1pt Actions Fleet: install Node pnpm CI
Installs Node pnpm CI (
node-pnpm-ci@1.2.0) from the sh1pt Actions Store.Files
.github/workflows/ci.yml— createRequired secrets
No new secrets required.
Notes
Generated by sh1pt Actions Fleet.