This repository was archived by the owner on Mar 29, 2021. It is now read-only.
WIP Split Console into Out/In/Error#17
Merged
gvolpe merged 2 commits intoprofunktor:masterfrom Nov 20, 2018
Merged
Conversation
gvolpe
approved these changes
Nov 20, 2018
Member
gvolpe
left a comment
gvolpe
left a comment
There was a problem hiding this comment.
LGTM, thanks! Feel free to add more tests for mapK but it's not mandatory :)
Member
|
It would be great to add docs for the new different consoles :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11.
TODO:
mapK?