This repository was archived by the owner on Mar 29, 2021. It is now read-only.
Add Console#mapK#9
Merged
gvolpe merged 4 commits intoprofunktor:masterfrom Nov 14, 2018
Merged
Conversation
Member
|
Go for the tests, looks great, thanks! |
Member
Author
|
Please take a look in a spare while :) |
Member
Author
|
Also note that this is binary breaking for <2.12, which I'm not sure you're concerned about below 1.0 |
Member
|
Thanks, will look into details tomorrow, gotta leave now (actually on small holidays :) ) |
Member
Author
|
Sure, have fun! |
gvolpe
reviewed
Nov 14, 2018
| override def putError[A: Show](a: A): F[Unit] = | ||
| out3.update(acc => acc ::: a.show :: Nil) | ||
| override def readLn: IO[String] = IO.pure("test") | ||
| override def readLn: F[String] = Applicative[F].pure("test") |
Member
There was a problem hiding this comment.
Nitpick: since we are already import all the syntax I'd rather do "test".pure[F] :)
gvolpe
approved these changes
Nov 14, 2018
Member
gvolpe
left a comment
gvolpe
left a comment
There was a problem hiding this comment.
Left a minor nitpick comment, the rest looks great, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial version, if it looks nice I'll add some tests :)