Skip to content

Chapter 2 - Recording changes#3

Closed
lagunex wants to merge 10 commits intoprogit:masterfrom
lagunex:master
Closed

Chapter 2 - Recording changes#3
lagunex wants to merge 10 commits intoprogit:masterfrom
lagunex:master

Conversation

@lagunex
Copy link
Contributor

@lagunex lagunex commented Mar 5, 2015

The pull request includes (by mistake) two set of changes:

  • The first three commits fix some typos in getting-a-repository.asc, a file that was previously translated.
  • The other commits correspond to full translations of new files in the sections sub-directory.

The commit messages are in Spanish. I understand we tend to write in English when coding and commenting but considering this is a Spanish translation of a book, I think Spanish commit messages in Spanish would be fine. I'm writing my first pull request message in English just in case.

I having troubles translating "commit" as a noun. As a verb I agree with "confirmar" but I didn't feel confortable using "confirmación" as the noun, so I used commit in italics (see http://www.rae.es/diccionario-panhispanico-de-dudas/que-contiene/tratamiento-de-los-extranjerismos).

I have plans to continue translating this chapter. How can we organize ourselves in order to avoid multiple translations of the same things? In the meantime, I call dibs on chapter 2 until further notice 😄

@lagunex
Copy link
Contributor Author

lagunex commented Mar 8, 2015

Here I finished chapter 2. I just found out the first version of the Spanish book and I'll use it to translate faster future chapters.
I'll also create a branch for each future chapter. I understand this is the standard way to work with pull-request, instead of pushing directly into master.

@lagunex lagunex closed this Mar 8, 2015
@lagunex
Copy link
Contributor Author

lagunex commented Mar 8, 2015

I closed this PR because it involved direct commits to the master branch. I replaced it with a PR using a topic branch.
Luckily, no one had taken any actions with this PR so there were no impacts with the change of history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant