Skip to content

Chapter 2. Git Basics#4

Merged
andres-mancera merged 10 commits intoprogit:masterfrom
lagunex:02-git-basics
Mar 9, 2015
Merged

Chapter 2. Git Basics#4
andres-mancera merged 10 commits intoprogit:masterfrom
lagunex:02-git-basics

Conversation

@lagunex
Copy link
Contributor

@lagunex lagunex commented Mar 8, 2015

The pull request includes (by mistake) two set of changes:

  • The first three commits fix some typos in getting-a-repository.asc, a file that was previously translated.
  • The other commits correspond to full translations of new files in the sections sub-directory.

The commit messages are in Spanish. I understand we tend to write in English when coding and commenting but considering this is a Spanish translation of a book, I think Spanish commit messages in Spanish would be fine. I'm writing my first pull request message in English just in case.

I having troubles translating "commit" as a noun. As a verb I agree with "confirmar" but I didn't feel confortable using "confirmación" as the noun, so I used commit in italics (see http://www.rae.es/diccionario-panhispanico-de-dudas/que-contiene/tratamiento-de-los-extranjerismos).

@lagunex
Copy link
Contributor Author

lagunex commented Mar 8, 2015

Here I finished chapter 2. I just found out the first version of the Spanish book and I'll use it to translate faster future chapters.
I'll also create a branch for each future chapter. I understand this is the standard way to work with pull-request, instead of pushing directly into master.

@lagunex lagunex changed the title 02-git-basics Chapter 2. Git Basics Mar 8, 2015
@andres-mancera
Copy link
Member

@lagunex : Gracias por tu ayuda con la traducción de estos capítulos. Tal y como lo has mencionado, para futuros pull requests, te agradecería que lo hicieras a través de un branch y no directamente al master. Saludos.

andres-mancera added a commit that referenced this pull request Mar 9, 2015
@andres-mancera andres-mancera merged commit bf0da18 into progit:master Mar 9, 2015
@lagunex lagunex deleted the 02-git-basics branch March 9, 2015 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants