Skip to content

Conversation

@jnavila
Copy link
Member

@jnavila jnavila commented Oct 26, 2014

I picked up another file

@ben
Copy link
Member

ben commented Oct 26, 2014

Whoops, nice catch. 👍

ben added a commit that referenced this pull request Oct 26, 2014
libgit2 contains no files named benchmarks.rb
@ben ben merged commit c9bac1d into master Oct 26, 2014
@jnavila
Copy link
Member Author

jnavila commented Oct 26, 2014

Well I was too quick on this PR. In fact the changes go far beyond just changing the file name. There are some changes to the ruby code in the git_diff_staged section.

@jnavila jnavila deleted the libgit2_file branch October 26, 2014 18:48
@ben
Copy link
Member

ben commented Oct 26, 2014

Do you want to continue down this path, or should we roll it back?

@jnavila
Copy link
Member Author

jnavila commented Oct 26, 2014

It depends more on you! In the first place, grit was replaced with libgit2. Reading the rest of the changes for the 2nd edition, this makes sense. I haven't gone through all the places that need fixing.

@schacon
Copy link
Member

schacon commented Oct 26, 2014

Yeah, I didn't really do it with the idea that people would try to re-enact everything more that you could see what it might look like. However, it's a good point that we don't want people to get confused if they do try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants