Skip to content

Conversation

@lazarljubenovic
Copy link
Contributor

The book used a combination of Markdown and Asciidoc syntax for
bold and italic text. In the documentation, it says that * are
used for highlighting the whole word or phrase, and ** are used
to highlight a part of the word. The render still worked fine
before, but the source-code now follows the semantics.

http://asciidoctor.org/docs/user-manual/#bold-and-italic

The book used a combination of Markdown and Asciidoc syntax for
bold and italic text. In the documentation, it says that * are
used for highlighting the whole word or phrase, and ** are used
to highlight a part of the word. The render still worked fine
before, but the source-code now follows the semantics.

http://asciidoctor.org/docs/user-manual/#bold-and-italic
@jnavila
Copy link
Member

jnavila commented Sep 4, 2015

We only highlight words. So this PR doesn't really make sense.

@lazarljubenovic
Copy link
Contributor Author

The book uses ** for highlighting whole words:

The first option ignores whitespace **completely** when comparing lines [...]

The Asciidoc documentation (my emphasis):

To render a word or phrase with bold styling, place an asterisk (*) at the beginning and end of the text you wish to format. To bold a letter or letters in a string of text, place two asterisks (**) before and after the letter or letters.

As their example clearly states, ** is used only for highlighting letters as parts of a word:

*charm*.
**u**ltimate

As you said, this book highlights only words and phrases, so it should use * instead of **.

I assume that the ** syntax this book uses is a leftover from the first edition when the book was written using Markdown because using * in Markdown renders italic and ** renders bold. In Asciidoc, * is used for bold words and phrases and _ is used for italic words and phrases.

ben added a commit that referenced this pull request Sep 8, 2015
Bold and italic follow Asciidoc semantics
@ben ben merged commit d73ca0b into progit:master Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants