Add ebook download links to progit3.com/book/ - #20
Merged
Conversation
Link PDF/EPUB/FB2/HTML from /book/ to the GitHub release assets that release-on-merge.yml attaches on every merge to main, via the stable releases/latest/download URLs. MOBI is not linked because the build does not actually produce it. Co-authored-by: Scott Chacon <schacon@gmail.com>
schacon
marked this pull request as ready for review
August 3, 2026 19:52
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Download:" row to the book index page (
/book/) on the site, linking PDF · EPUB · FB2 · HTML as pill-style links next to the book cover.The links point at the stable GitHub
releases/latest/download/...URLs —release-on-merge.ymlattaches these four files to a new release on every merge to main, so the links always serve the most recent build with no site changes needed per release. MOBI is deliberately not linked: the workflow lists it, but the currentasciidoctor-epub3toolchain never produces it (known no-op), so a link would 404.Verification
npm run buildinsite/succeeds; the generated/book/page contains all four links (verified indist/).https://github.com/progit/progit3/releases/latest/download/progit.pdfresponds with a 302 to the current release asset (2.1.17 has all four files).