Use JetBrains Mono as the PDF code font - #21
Merged
Conversation
Add a PDF theme (theme/pdf/progit-theme.yml) extending the default Asciidoctor PDF theme with JetBrains Mono (v2.304, OFL, bundled in theme/pdf/fonts) for codespan, code blocks, and kbd. Callout numbers keep the default M+ 1mn font for its circled-number glyphs. Wire the theme into both the Rake task and the Rust builder. Co-authored-by: Scott Chacon <schacon@gmail.com>
schacon
marked this pull request as ready for review
August 3, 2026 19:53
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the monospace font in the PDF from the default M+ 1mn to JetBrains Mono for inline code (
codespan), code blocks (code), andkbdmacros.theme/pdf/progit-theme.yml— new PDF theme extending the asciidoctor-pdf default; only the mono font changes. Callout numbers (conum) intentionally keep M+ 1mn, which provides the circled-number glyphs (①②③).theme/pdf/fonts/— JetBrains Mono v2.304 TTFs (Regular/Bold/Italic/BoldItalic), vendored with its OFL license file.Rakefileandbuilder/src/tasks.rs— both PDF invocations passpdf-themeand apdf-fontsdirthat includes the bundled fonts plusGEM_FONTS_DIR(so the default theme's other fonts keep resolving).Verification
asciidoctor-pdfrun with the theme completes with zero warnings (no missing glyphs), andrake book:build_pdfworks with the new arguments.