Skip to content

Conversation

@InesSalome
Copy link
Contributor

As I said in the issue #2059, I propose to add few precisions to help install Jekyll with Github Desktop on a Mac. I've added in reviewers two of the contributors of the lesson (@mariechristineb and @acrymble).

Let me know if there is a problem or it's not relevant !

@acrymble
Copy link

@InesSalome I know you may be wondering why you are still waiting for a response here. The problem is some confusion about who can make these types of changes to published lessons. Only the managing editor of a lesson can approve changes to a lesson that is already published. In the case of an English lesson that is @svmelton.

We put that rule in place to make sure that the Managing Editor has full editorial control of her publication.

It's great that you want to get involved, and nobody wants to discourage that. But I think you will find that no one will approve changes to a published lesson in this way.

@InesSalome InesSalome requested a review from svmelton March 11, 2021 17:31
@InesSalome
Copy link
Contributor Author

Thank you for the explanation @acrymble and sorry for the blunder, I will remember the process for the next time ! I added @svmelton in the reviewers, but I understood that my second proposition (adding sudo in the command line) is not a good solution, so would you like me to add my first idea in the lesson or it's not necessary (I'm referring to the propositions evoked in the issue) ? :)

@spapastamkou
Copy link
Contributor

@InesSalome I updated the branch to sync, if you are happy with the preview you can merge.

@InesSalome InesSalome merged commit 6d7fa0c into gh-pages Mar 17, 2021
@spapastamkou spapastamkou deleted the issue-2059 branch March 17, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants