Fix Storybook build: react-docgen stack overflow in config.ts - #732
Merged
Conversation
react-docgen's resolveToValue recurses infinitely on a let variable that is conditionally assigned and then reassigned multiple times, causing "Maximum call stack size exceeded" during `npm run build-storybook`. Compute API_BASE_URL once via a helper instead of reassigning it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-docs.yml) fails atnpm run build-storybookwithRangeError: Maximum call stack size exceededinsidereact-docgen.react-docgen'sresolveToValuerecurses infinitely when aletvariable is conditionally assigned and then reassigned again afterward — exactly the patternAPI_BASE_URLhad infrontend/src/config.ts.API_BASE_URLonce via a helper function returning aconst, removing the reassignment chain that trips up docgen. No behavior change.Test plan
npm run build-storybookcompletes successfully locally (previously failed with the stack overflow)frontend/src/config.tslogic unchanged (env var → localhost → origin fallback, then strip/api/v1and trailing slash)🤖 Generated with Claude Code