[FIX] Increasing Tests Coverage Back to The Threshold#101
Merged
antonio-amjr merged 2 commits intoJul 8, 2026
Merged
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive suite of unit tests for LogStreamHandler and LogsHTTPServer, covering error handling, tree state initialization, node updates, and various log streaming edge cases. The reviewer feedback focuses on enhancing the robustness of these tests by replacing loose assertions (such as assert_called) with precise ones (like assert_called_once_with) and ensuring that synchronization locks are explicitly verified as acquired.
rquidute
approved these changes
Jul 8, 2026
oxesoft
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
log_stream_handler.pyandlogs_http_server.pyto reflect the broadcast-pattern refactor (per-client queues replacing the sharedlog_queue)init_tree(),update_tree_node(),_build_tree(),_get_state(),serve_status(), tree snapshot path, keepalive, tree event routing, and all exception handlers