[Feature] Swap CLI Properties Config With JSON

[antonio-amjr]

Fix: project-chip/certification-tool#824

Description

Swapping the .properties config file format for the already used JSON format when running a test execution. Both the full JSON file (with name and config) and the partial JSON (config-only data) are compatible.

The reason behind this change is to utilize only JSON files as configuration option to simplify for the user, for all the commands that require or has config options to run with.

Impact

The th-cli run-tests --config command is impacted with this change.

Testing

• All unit tests passing (including the new additions)
• Both JSON format tested briefly with some TCs
• Manual verification of the resulted config during execution (see image below)

[gemini-code-assist]

Summary of Changes

Hello @antonio-amjr, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the configuration management for the th-cli run-tests command by migrating from .properties files to a unified JSON format. This enhancement simplifies the user experience by allowing a single configuration file to be used across various CLI operations, promoting consistency and reducing potential friction when managing test execution settings. The change involves updating the command-line interface, refactoring internal configuration parsing and merging logic, and updating documentation and test fixtures to reflect the new JSON-centric approach.

Highlights

• Configuration File Format Transition: The th-cli run-tests --config command now exclusively uses JSON configuration files, replacing the older .properties format. This change standardizes configuration across the CLI.
• Flexible JSON Configuration: The --config flag supports two JSON formats: a 'config-only' structure and a 'full project format' (which automatically extracts the configuration), ensuring compatibility with project create and project update commands.
• Refactored Configuration Utilities: New utility functions load_json_config and merge_configs have been introduced for robust JSON parsing and deep merging, replacing the deprecated properties-based functions.
• Updated Default Configuration: The default_config.properties file has been removed and replaced with th_cli/default_config.json, providing a JSON-native default configuration.
• Comprehensive Testing: All unit tests, including new ones for JSON handling, are passing. Both JSON formats were briefly tested, and manual verification of the configuration during execution was performed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively replaces the .properties configuration file format with JSON for test executions. The changes are well-implemented across the codebase, including updates to the command logic, utility functions, and comprehensive unit tests. The documentation in README.md has also been updated clearly.

Key improvements include:

• A new load_json_config utility that robustly handles two different JSON formats (config-only and full project).
• A new merge_configs utility for deep-merging configurations.
• Extensive and well-written unit tests for the new utility functions.
• Improved code quality in run_tests.py with better function names, type hints, and detailed docstrings.

The overall implementation is solid and enhances the tool's configuration handling. I have one minor suggestion regarding file formatting.

[rquidute]

Well done.