Fix test case comparison logic

[rquidute]

What changed

Fixes a bug in the CLI where test IDs with mixed-case letters (e.g. TC_WebRTCP_2_2) were not matched when the user provided a different case variant (e.g. TC_WEBRTCP_2_2), causing the test run to end as NOT_APPLICABLE.

Related Issue

project-chip/certification-tool#902

Testing

Running th-cli run-tests -t TC_WEBRTCP_2_2 --project-id 11 no longer results in NOT_APPLICABLE due to test not found.

TC_WEBRTCP_2_1 running successfully with this command: th-cli run-tests --tests-list TC_WEBRTCP_2_1 --project-id 1

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the test execution framework by addressing an issue where test cases with mixed-case IDs were not correctly recognized. By standardizing test ID comparisons to be case-insensitive, it ensures that tests can be reliably selected regardless of the casing used in their identifiers, improving the overall reliability of test execution.

Highlights

• Test Case Comparison Logic: Modified the test case selection logic to perform case-insensitive comparisons by converting both the provided test IDs and the internal test case IDs to uppercase before matching.
• Error Message Formatting: Refactored the CLIError message for json.JSONDecodeError to be a single line for improved readability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• th_cli/utils.py
  • Updated the build_test_selection function to convert input tests_list IDs to uppercase for case-insensitive matching.
  • Modified the build_test_selection function to convert test_case_id from test collections to uppercase for case-insensitive comparison.
  • Refactored the CLIError message for json.JSONDecodeError within load_json_config to a single line.

Activity

• The author identified and fixed an issue where test cases with lowercase characters in their IDs were not being correctly matched, leading to them being marked as 'Not Applicable'.
• Testing was performed by running th-cli run-tests -t TC_WEBRTCP_2_2 --project-id 11, which now correctly attempts to execute the test instead of marking it as 'Not Applicable'.
• A note was added indicating that after the changes, the TC_WebRTCP_2_2 test is now failing, but this failure is unrelated to the current pull request's changes and is due to a ValueDecodeFailure related to CameraAvStreamManagement attributes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes the test case comparison logic by making it case-insensitive. The changes in th_cli/utils.py properly convert test case IDs to uppercase on both sides of the comparison. I have one minor suggestion regarding a stylistic change to an f-string for improved readability, but the core logic of the PR is sound.