Prevent PydanticUserError in ApiClient.send for void endpoints (#90) - #94
Merged
Conversation
Short-circuit and return None before constructing TypeAdapter when type_ is None (e.g. 204 No Content endpoints). TypeAdapter(None) raises PydanticUserError, and returning None matches the existing overloads. Closes #90 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the client generation script to handle cases where the expected response type is None by returning None early, and simplifies the JSON parsing logic. The reviewer pointed out that void endpoints returning 204 No Content are not currently supported and will raise an UnexpectedResponse exception, suggesting that 204 should be included in the allowed status codes and handled appropriately.
Add 204 to the success status codes and short-circuit to None for it so void endpoints stop raising UnexpectedResponse. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
rquidute
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApiClient.send, returnNoneimmediately whentype_isNoneinstead of callingTypeAdapter(type_), which raisesPydanticUserErrortype_: None -> Noneoverloads, fixing 204 No Content (and other void-response) endpointsCloses #90
Test plan
python3 -m py_compile scripts/datamodel_generate_client.pyNonewithout raising🤖 Generated with Claude Code