"is_commissioning" is a misleading name.

[OlivierGre]

Describe the bug

TH uses a variable called "is_commissioning". This name is a bit misleading: This variable is in fact controlling if a commissioning is launched automatically by the TH env. It might be useful to use a different name.

Because of this, tests TC_DD_3_23 and TC_DD_3_24 currently fall in "No commissioning" category whereas they are commissioning test. The only thing is that the commissioning is not triggered automatically by the TH env but by the test. So the category could be renamed as well.

Steps to reproduce the behavior

No response

Expected behavior

No response

Log files

No response

PICS file

No response

Screenshots

No response

Environment

No response

Additional Information

No response

[rquidute]

The TH-side rename (PythonTestType, SuiteType) is straightforward and low risk. However, is_commissioning is part of the SDK TestStep API and appears in 370+ SDK test scripts — that would need to be a separate upstream SDK change.
CC @cecille @raju-apple @oxesoft

[OlivierGre]

Hi Romulo,
In that case, IMO it is not worth making that change.

[OlivierGre]

@rquidute
What do you think of renaming the test suites categories:

The tests are currently in 2 categories:

• Python Testing Suite
• Python Testing Suite - No commissioning

We could rename them:

• Python Testing Suite - Automatic commissioning
• Python Testing Suite - No automatic commissioning
  ?

[rquidute]

Reopening this issue, as it can be addressed by renaming the test suites.

[rquidute]

Hi @OlivierGre, I would suggest a slight change:
Python Testing Suite - Auto commissioning
Python Testing Suite - No auto commissioning
What do you think?

[OlivierGre]

Hi @OlivierGre, I would suggest a slight change: Python Testing Suite - Auto commissioning Python Testing Suite - No auto commissioning What do you think?

Hi Romulo,
That looks good :)
Thank you