Skip to content

[Bug]: Wikidata Guesser Needs Refactor #199

@kkdavis14

Description

@kkdavis14

Priority Level

Low

What happened?

Some of the properties in use to guess a Class aren't effective:

p571 (inception) as a metric for assigning the class of HumanMadeObject is a problem as lots of things that aren’t objects have p571, e.g.:
https://www.wikidata.org/wiki/Q43173
https://lux.collections.yale.edu/view/object/2aba9c00-814a-4bbb-b30d-db267fe330e9

P580, P582 (start and end time) and P571 can be used interchangeably by Wikipedians. Generally the prior are for events, but P571 is used often one Events and Objects. I think it's safe to use the prior as a metric for Events, especially because they have so few other valid properties, but not safe to use the latter as a metric for Objects (or at all).

Wikidata mapper should account for Activities in Guesser.

Relevant log output

No response

Additional Tasks

  • Refactor the guess_type function in Wikidata Mapper to better suit current LUX requirements

Metadata

Metadata

Assignees

Labels

bugThe code does not behave as expected / designed

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions