updated wikidata mapper, expanded guesser and activity mapping #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azaroth42
requested changes
Jan 22, 2025
Collaborator
azaroth42
left a comment
azaroth42
left a comment
There was a problem hiding this comment.
Small tweak re get_reference, otherwise looks good
| top.part_of = model.Activity(ident=self.expand_uri(b)) | ||
| pref = self.get_reference(b) | ||
| if pref and pref.__class__ == model.Period: | ||
| top.part_of = model.Period(ident=self.expand_uri(b)) |
Collaborator
There was a problem hiding this comment.
Can't this just be top.part_of = pref ? No need to test pref.class, just if it's not None.
Author
There was a problem hiding this comment.
Hm. I think I was confused because both process_period and process_event just point to process_activity. Maybe I should split up the process_activity code to each more specific Class, e.g. Periods don't have participants. I'll write that up and re-submit.
…s_period_record function
azaroth42
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is certainly an art not a science trying to map Wikidata, but I think this is a general improvement and hopefully will result in better HMOs, Periods and Activities making it to LUX.
closes #199