Add full send queue support for sending messages/attachments - #1055
Merged
Conversation
* Local echoes of unsent messages now show a sending status indicator which is in the same spot as the AvatarRow of read receipts. * It shows everything from sending, upload progress, queued offline, failed, to fully sent, with nice icons and colors too. * The user can retry or cancel a failed send from the message menu. * You can now send messages while offline, and they get enqueued; upon coming back online, they'll be sent automatically. * We also now route attachment uploads through the queue, and the user sees more fine-grained updates like "Encrypting", "X% uploaded", "Sending". We also discovered a bug in the matrix SDK that makes uploads unnecessarily large and thus slower, see here: <matrix-org/matrix-rust-sdk#6976>
that doesnt' make sense because a "saved" location draft will by definition be stale. It's better to force the user to explicitly re-open the location sending pane
one key issue we missed is that a `RoomScreen` can be reused for a different timeline while an upload is still happening in the background, so we need to ensure that we don't mistakenly show the upload progress for a different room's upload. we now properly handle that via the classic save/restore state pair of functions, and save it in the `RoomInputBarState`. This also cleanly allows multiple uploads in separate rooms run and be displayed at the same time. also fix typos and clippy
and fix typos again lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
indicator which is in the same spot as the AvatarRow of read receipts.
failed, to fully sent, with nice icons and colors too.
upon coming back online, they'll be sent automatically.
sees more fine-grained updates like "Encrypting", "X% uploaded", "Sending".
We also discovered a bug in the matrix SDK that makes uploads unnecessarily large and thus slower, see here:
matrix-org/matrix-rust-sdk#6976