feat: add Amazon-ad-console ECC bundle - #56
Merged
Conversation
…ole/agents/openai.yaml)
…inherited/Amazon-ad-console-instincts.yaml)
…gfix-with-test.md)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
projectamazonph
pushed a commit
that referenced
this pull request
Aug 3, 2026
…ructure The database has been Postgres (via @prisma/adapter-neon) since the B-04 audit fix, but README.md, AGENTS.md, and several docs/ files still described SQLite as current — including a literal `provider = "sqlite"` schema snippet and `file:./dev.db` env examples that would produce a broken setup if followed today. Fixed all current-state references (left docs/AUDIT-FOLLOWUPS.md's historical finding and docs/HANDOFF.md's dated 2026-07-20 snapshot alone, since both are accurate records of a specific point in time, not claims about the app today). Also fixed the env var names to match .env.example / src/lib/auth.ts (AUTH_SECRET, not NEXTAUTH_SECRET/NEXTAUTH_URL — this repo runs NextAuth v5's Auth.js env var convention and doesn't need a URL var at all). Other fixes: - README's project structure tree still showed core/ as a flat 3-file module and CreateCampaignWizard.tsx as a top-level file; updated to match the real core/engine + core/slices split and the wizard/ subdirectory with per-ad-type steps. - README's Tech Stack table was missing Astryx (153 components, actively used across ~40 files) entirely. - README's pre-built-campaign table listed campaign #3's targeting mode as "Video creative" — that's the ad format, not targetingMode (which is actually 'Keyword'); corrected. - README claimed "8 slices" for the Zustand store; it's 8 core slices + 7 feature slices (15 total), per CLAUDE.md. - docs/TECH-SPECS.md's file-statistics table was stale in both directory shape and line counts (e.g. citing a single 600-line engine.ts that hasn't existed since the engine/ split); refreshed with real counts and dated the snapshot so future staleness is at least self-documenting. - Linked the new CHANGELOG.md and existing-but-unlinked docs/DEPLOYMENT.md from README's Documentation section. - CLAUDE.md: documented the new .claude/.agents/.codex ECC bundle (PR #56) and flagged that its auto-generated skill file contains at least one inaccurate claim (invented camelCase filename examples that don't match this repo's real PascalCase-components / lowercase-engine-modules convention) — CLAUDE.md remains the authoritative source when they disagree.
3 tasks
projectamazonph
added a commit
that referenced
this pull request
Aug 3, 2026
…ructure (#59) * Update README and docs: fix stale SQLite/NextAuth references, sync structure The database has been Postgres (via @prisma/adapter-neon) since the B-04 audit fix, but README.md, AGENTS.md, and several docs/ files still described SQLite as current — including a literal `provider = "sqlite"` schema snippet and `file:./dev.db` env examples that would produce a broken setup if followed today. Fixed all current-state references (left docs/AUDIT-FOLLOWUPS.md's historical finding and docs/HANDOFF.md's dated 2026-07-20 snapshot alone, since both are accurate records of a specific point in time, not claims about the app today). Also fixed the env var names to match .env.example / src/lib/auth.ts (AUTH_SECRET, not NEXTAUTH_SECRET/NEXTAUTH_URL — this repo runs NextAuth v5's Auth.js env var convention and doesn't need a URL var at all). Other fixes: - README's project structure tree still showed core/ as a flat 3-file module and CreateCampaignWizard.tsx as a top-level file; updated to match the real core/engine + core/slices split and the wizard/ subdirectory with per-ad-type steps. - README's Tech Stack table was missing Astryx (153 components, actively used across ~40 files) entirely. - README's pre-built-campaign table listed campaign #3's targeting mode as "Video creative" — that's the ad format, not targetingMode (which is actually 'Keyword'); corrected. - README claimed "8 slices" for the Zustand store; it's 8 core slices + 7 feature slices (15 total), per CLAUDE.md. - docs/TECH-SPECS.md's file-statistics table was stale in both directory shape and line counts (e.g. citing a single 600-line engine.ts that hasn't existed since the engine/ split); refreshed with real counts and dated the snapshot so future staleness is at least self-documenting. - Linked the new CHANGELOG.md and existing-but-unlinked docs/DEPLOYMENT.md from README's Documentation section. - CLAUDE.md: documented the new .claude/.agents/.codex ECC bundle (PR #56) and flagged that its auto-generated skill file contains at least one inaccurate claim (invented camelCase filename examples that don't match this repo's real PascalCase-components / lowercase-engine-modules convention) — CLAUDE.md remains the authoritative source when they disagree. * Restore top-level types.ts/scenarios.ts in README's structure tree Copilot review flagged that these two backward-compat re-export files (export * from './core/types' / './core/scenarios') were dropped when the tree was resynced — they still exist and are real navigation points, unlike the engine.ts single-file that was correctly removed. * Address CodeRabbit findings: adapter wiring location, deps, migrate deploy - docs/AUTH.md: clarified that prisma/schema.prisma only declares the postgresql provider — the DATABASE_URL/adapter-neon runtime wiring lives in prisma.config.ts / src/lib/prisma.ts, not the schema. - docs/AUTH.md + docs/TECH-SPECS.md: added the two Neon packages (@prisma/adapter-neon, @neondatabase/serverless) to the install command and dependency table; also refreshed the dependency table's stale versions (^5.0.0 Prisma, ^11.0.0 motion, etc. — actual package.json has 7.8.0/12.42.2) and added the Astryx/phosphor-icons/ dotenv packages that were missing from it entirely. Dropped the "total runtime dependency count" line in favor of pointing at package.json, since a hardcoded count is exactly the kind of number that goes stale silently. - docs/AUTH.md + docs/TECH-SPECS.md: distinguished `migrate dev` (local development) from `migrate deploy` (production/CI — doesn't prompt interactively). - README.md: added docs/DEPLOYMENT.md and docs/AUDIT-FOLLOWUPS.md to the project structure tree, matching the Documentation section's links. --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Auto-generated ECC bundle from repository analysis.
What This Does
Merging this PR adds repo-local ECC artifacts for both Claude Code and Codex. The generated bundle captures repository patterns, Codex baseline config, and reusable workflow scaffolds derived from git history analysis.
Analysis Scope
Files
.claude/ecc-tools.json.claude/skills/Amazon-ad-console/SKILL.md.agents/skills/Amazon-ad-console/SKILL.md.agents/skills/Amazon-ad-console/agents/openai.yaml.claude/identity.json.codex/config.toml.codex/AGENTS.md.codex/agents/explorer.toml.codex/agents/reviewer.toml.codex/agents/docs-researcher.toml.claude/homunculus/instincts/inherited/Amazon-ad-console-instincts.yaml.claude/commands/engine-bugfix-with-test.md.claude/commands/api-route-bugfix-with-test.mdOptional: Continuous Learning (25 instincts)
This PR also includes instincts for the continuous-learning-v2 skill. These are optional and only useful if you use that skill.
Import after merging:
Review Checklist
ECC Tools | Everything Claude Code