[quality] ublue-bling shell config injection has no behavior tests

[clubanderson]

Finding

system_files/shared/usr/bin/ublue-bling manages shell configuration injection for bash, zsh, and fish. It modifies user dotfiles (.bashrc, .zshrc, config.fish) by injecting/removing source blocks.

Key untested logic:

• Shell detection and config file path resolution ($SHELL → config path)
• is-bling-installed detection function
• sed-based block removal (the ### source start / ### source end marker pattern)
• Fallback removal for single-line source entries
• Config file creation vs append behavior

Risk: Incorrect sed patterns or edge cases (empty file, missing markers, special characters in paths) could corrupt user shell configs.

Recommendation

1. Write bats tests for:
   • Shell detection → correct config file path mapping (bash→.bashrc, zsh→.zshrc, fish→config.fish)
   • is-bling-installed returns correct status for installed/not-installed states
   • Block injection creates correct markers
   • Block removal with markers works cleanly
   • Fallback removal (single grep-based line removal)
   • Handles missing config file gracefully
2. Mock gum confirm by overriding in PATH with a stub
3. Add to unit-tests.yml workflow

Priority

• Impact: medium (user dotfile corruption possible but recoverable)
• Effort: low (straightforward bash function testing)

---

Filed by quality agent (hold-gated mode)

Common · issue pipeline

  ▶  triage     needs kind/ + area/ then /approve
  ·  discussing —
  ·  queued     —
  ·  claimed    —
  ·  done       —

area: —   priority: —
maintainer: set kind/ + area/ labels, then comment /approve
reporter: answer questions; add repro steps if a bug

[clubanderson]

Ready-to-merge test implementation

I've written and locally validated a bats test file (tests/test_bling.bats) covering all the recommended test cases. All 10 tests pass.

The test file is ready to be added to the repo — I was unable to push a branch due to app token permissions (contents:write not available).

How to apply

# From repo root, create tests/test_bling.bats with the content below,
# then run: bats tests/test_bling.bats

Test coverage (10 tests)

1. ✅ bash shell maps to .bashrc
2. ✅ zsh shell maps to .zshrc
3. ✅ fish shell maps to config.fish
4. ✅ unknown shell exits with error
5. ✅ is-bling-installed returns 0 when source line present
6. ✅ is-bling-installed returns 1 when source line absent
7. ✅ is-bling-installed returns 1 when config file missing
8. ✅ bling install adds correct source block markers
9. ✅ bling uninstall removes block between markers
10. ✅ bling uninstall preserves file when markers not found

Integration with CI

Add to unit-tests.yml after existing bats steps:

      - name: Run bats (bling)
        run: bats tests/test_bling.bats

---

Quality agent — test validated locally, PR blocked by token permissions

[castrojo]

Fix implemented in PR #568 (feat(testing): expand shellcheck + add bats) — awaiting review.

What landed: tests/test_bling.bats with 9 tests covering:

• install/uninstall idempotency
• is-bling-installed detection
• block injection with correct markers
• block removal (marker + fallback path)
• no stray stdout on install

CI: bats step added to unit-tests.yml. Mocking via PATH stub pattern for gum.