[quality] unit-tests.yml is missing 8 test files already in tests/ (4 bats + 4 Python)

[kubestellar-hive]

Finding

unit-tests.yml is missing 8 test files that already exist in tests/ and are exercised by just test.

Missing bats tests (4)

Test file	What it covers
test_hardware_hooks.bats	10-framework.sh and 11-asus.sh system-setup hooks
test_theming_hook.bats	10-theming.sh user-setup hook
test_nvidia_flatpak_sync.bats	ublue-nvidia-flatpak-runtime-sync script
test_ujust.bats	ujust wrapper on-demand fzf installation

Note: test_libvirt_helper.bats is intentionally excluded (requires running libvirtd; documented in Justfile).

Missing Python tests (4)

Test file	What it covers	Extra dep
test_bazaar_hook.py	bazaar-hook libexec (JetBrains/VSCode redirect logic)	—
test_check_oci_refs.py	scripts/check-oci-refs.py (tag/ref validation)	—
test_curated_config.py	Bazaar curated.yaml + bazaar.yaml structure	pyyaml
test_skill_docs.py	scripts/check-doc-links.sh, skill frontmatter, index	—

Fix

16-line diff to .github/workflows/unit-tests.yml — no new tests needed, they already exist:

-          pip install pytest pytest-cov
+          pip install pytest pytest-cov pyyaml

+      - name: Run pytest (bazaar-hook, check-oci-refs, curated-config, skill-docs)
+        run: python3 -m pytest tests/test_bazaar_hook.py tests/test_check_oci_refs.py tests/test_curated_config.py tests/test_skill_docs.py -v

+      - name: Run bats (hardware hooks — framework + asus)
+        run: bats tests/test_hardware_hooks.bats
+
+      - name: Run bats (theming hook)
+        run: bats tests/test_theming_hook.bats
+
+      - name: Run bats (nvidia flatpak runtime sync)
+        run: bats tests/test_nvidia_flatpak_sync.bats
+
+      - name: Run bats (ujust — fzf on-demand install)
+        run: bats tests/test_ujust.bats

Branch quality/ci-sync-missing-tests has the commit ready; push was blocked because the App lacks workflows permission.

Priority

• Impact: high — 8 test files silently skipped on every PR; regressions in hardware hooks, theming, nvidia sync, and ujust go undetected
• Effort: low — copy-paste diff above, no new test code needed

---

Filed by quality agent (hold-gated mode)

[kubestellar-hive]

Verified all 9 orphaned test files locally against main (@ 726e853):

• bats — test_ujust.bats, test_clean_system_podman_path.bats, test_hardware_hooks.bats, test_theming_hook.bats, test_nvidia_flatpak_sync.bats → 35 passed
• pytest — test_bazaar_hook.py, test_check_oci_refs.py, test_curated_config.py, test_skill_docs.py → 60 passed

95 tests pass today and none of them run in CI. No new test code is needed, only workflow wiring.

Two corrections to the issue as filed:

1. It is 9 files, not 8 — tests/test_clean_system_podman_path.bats is also in just test but missing from unit-tests.yml.
2. test_skill_docs.py imports scripts/generate_skill_index.py, which needs jsonschema. Without it 4 tests error on import, so the pip line needs jsonschema alongside pyyaml.

Also worth folding in: the new pytest step covers scripts/check-oci-refs.py, scripts/generate_skill_index.py and docs/skills/**, none of which are in the workflow's paths filter — so scripts/** and docs/** need adding or the tests will not fire on the changes they guard.

I could not open a PR for this: the hive App token has no workflows permission, and GitHub rejects any push that touches .github/workflows/** (refusing to allow a GitHub App to create or update workflow ... without workflows permission). This one needs a maintainer.

Related: #1031 adds BATS coverage for system.just and hits the same wall — the test file is wired into just test but its CI step has to be added by hand.

---

Filed by quality agent (hold-gated mode)

🐝 Hive Agent: quality | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: 760192c

— hive: agent=quality backend=copilot model=claude-opus-5