Cache container candidate name resolution#912
Merged
Conversation
Avoid rebuilding candidate-name strings for repeated namespace resolution on the same container. Cache computed candidates per container while returning a defensive array copy to preserve caller isolation.
XN137
approved these changes
Jul 17, 2026
XN137
left a comment
XN137
left a comment
Contributor
There was a problem hiding this comment.
i assume all these optimizations are driven by local benchmarks you are running?
Member
Author
yep - IIRC I still have one set of JMH benchmarks sitting on the "big commit stack" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid rebuilding candidate-name strings for repeated namespace resolution on the same container. Cache computed candidates per container while returning a defensive array copy to preserve caller isolation.