Add performance-focused JMH benchmark - #922
Merged
Merged
Conversation
XN137
previously approved these changes
Jul 21, 2026
| return; | ||
| case "all": | ||
| program = program("items.all(i, i >= 0)"); | ||
| vars = mapOf("items", list(size), "target", (long) size - 1); |
Contributor
There was a problem hiding this comment.
target is unused in the expression
| } | ||
|
|
||
| @Benchmark | ||
| public void enumConversion(Blackhole blackhole) { |
Contributor
There was a problem hiding this comment.
are we intentionally including registry creation and enum registration in this benchmark?
these parts are already covered in registerEnum and probably much more "expensive" than the conversion itself?
|
|
||
| @Benchmark | ||
| public void registerType(Blackhole blackhole) { | ||
| Jackson3Registry registry = (Jackson3Registry) Jackson3Registry.newRegistry(); |
Contributor
There was a problem hiding this comment.
should we measure registry creation separately and then exclude it from the individual operation benchmarks?
| case "mapLookupMiss": | ||
| program = | ||
| protoProgram( | ||
| "msg.map_string_uint64[key] == target", |
Contributor
There was a problem hiding this comment.
pardon my ignorance: does this run into an error or evaluate to False?
XN137
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.