Skip to content

add docker build job in goreleaser + Dockerfile #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2020
Merged

add docker build job in goreleaser + Dockerfile #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0c28e0
add docker build job in goreleaser + Dockerfile
Nexucis May 31, 2020
35e7c0b
manually login into the docker registry
Nexucis May 31, 2020
44b15c2
add quay.io registry
Nexucis Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:

steps:
- checkout
- setup_remote_docker
- restore_cache:
keys:
- v4-crossbuild-cache
Expand All @@ -41,9 +42,12 @@ jobs:

steps:
- checkout
- setup_remote_docker
- restore_cache:
keys:
- v4-crossbuild-cache
- run: docker login docker.io -u $DOCKER_LOGIN -p $DOCKER_PASSWORD
- run: docker login quay.io -u $QUAY_LOGIN -p $QUAY_PASSWORD
- run: cd ..; GO111MODULE=on go get github.com/goreleaser/goreleaser@v0.131.1
- run: git reset --hard
- run: make release
Expand Down
15 changes: 15 additions & 0 deletions .goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,18 @@ checksum:
name_template: 'checksums.txt'
snapshot:
name_template: "{{ .Tag }}-next"
dockers:
-
goos: linux
goarch: amd64
Copy link
Member

@slrtbtfs slrtbtfs May 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess having images for other architectures (at least arm64) doesn't hurt.

Copy link
Contributor Author

@Nexucis Nexucis May 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would mean I have to create multiple different configuration to create and push the docker image. I'm not sure it's worth it.
We could still do it later if someone is asking. But I doubt a bit on that.

binaries:
- promql-langserver
image_templates:
- "docker.io/prometheuscommunity/promql_langserver:latest"
- "docker.io/prometheuscommunity/promql_langserver:{{ .Tag }}"
- "docker.io/prometheuscommunity/promql_langserver:v{{ .Major }}"
- "docker.io/prometheuscommunity/promql_langserver:v{{ .Major }}.{{ .Minor }}"
- "quay.io/prometheuscommunity/promql_langserver:latest"
- "quay.io/prometheuscommunity/promql_langserver:{{ .Tag }}"
- "quay.io/prometheuscommunity/promql_langserver:v{{ .Major }}"
- "quay.io/prometheuscommunity/promql_langserver:v{{ .Major }}.{{ .Minor }}"
7 changes: 7 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
FROM scratch

LABEL maintainer="The Prometheus Authors <prometheus-developers@googlegroups.com>"

COPY promql-langserver /bin/promql-langserver

ENTRYPOINT [ "/bin/promql-langserver" ]