Skip to content

Comments

Makefile: remove assets-tarball#5023

Merged
SoloJacobs merged 1 commit intoprometheus:mainfrom
SoloJacobs:remove-dead-make-target
Feb 22, 2026
Merged

Makefile: remove assets-tarball#5023
SoloJacobs merged 1 commit intoprometheus:mainfrom
SoloJacobs:remove-dead-make-target

Conversation

@SoloJacobs
Copy link
Contributor

The original commit made alertmanager-web-ui-{version}.tar.gz available as a release artefact for downstream consumption, see #2893

However, we stopped shipping this with the removal of the circle CI, as can been seen by comparing:
https://github.com/prometheus/alertmanager/releases/download/v0.28.1/alertmanager-web-ui-0.28.1.tar.gz and
https://github.com/prometheus/alertmanager/releases/tag/v0.29.0

So, this code can be removed without any effect. Because we are moving to //go:embed, it is not helpful to fix this issue.

Pull Request Checklist

Please check all the applicable boxes.

  • Please list all open issue(s) discussed with maintainers related to this change
    • Fixes #
  • Is this a new Receiver integration?
  • Is this a bugfix?
    • I have added tests that can reproduce the bug which pass with this bugfix applied
  • Is this a new feature?
    • I have added tests that test the new feature's functionality
  • Does this change affect performance?
    • I have provided benchmarks comparison that shows performance is improved or is not degraded
      • You can use benchstat to compare benchmarks
    • I have added new benchmarks if required or requested by maintainers
  • Is this a breaking change?
    • My changes do not break the existing cluster messages
    • My changes do not break the existing api
  • I have added/updated the required documentation
  • I have signed-off my commits
  • I will follow best practices for contributing to this project

Which user-facing changes does this PR introduce?

None

The original commit made `alertmanager-web-ui-{version}.tar.gz`
available as a release artefact for downstream consumption, see
prometheus#2893

However, we stopped shipping this with the removal of the circle CI, as
can been seen by comparing:
https://github.com/prometheus/alertmanager/releases/download/v0.28.1/alertmanager-web-ui-0.28.1.tar.gz
and
https://github.com/prometheus/alertmanager/releases/tag/v0.29.0

So, this code can be removed without any effect. Because we are moving
to `//go:embed`, it is not helpful to fix this issue.

Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
@SoloJacobs SoloJacobs merged commit b3a322a into prometheus:main Feb 22, 2026
7 checks passed
@SoloJacobs SoloJacobs deleted the remove-dead-make-target branch February 22, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants