fix (ui): Use single FileServer#5024
Merged
SoloJacobs merged 2 commits intoprometheus:mainfrom Feb 22, 2026
Merged
Conversation
The original commit made `alertmanager-web-ui-{version}.tar.gz`
available as a release artefact for downstream consumption, see
prometheus#2893
However, we stopped shipping this with the removal of the circle CI, as
can been seen by comparing:
https://github.com/prometheus/alertmanager/releases/download/v0.28.1/alertmanager-web-ui-0.28.1.tar.gz
and
https://github.com/prometheus/alertmanager/releases/tag/v0.29.0
So, this code can be removed without any effect. Because we are moving
to `//go:embed`, it is not helpful to fix this issue.
Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Previously, we spawned one `FileServer` per `GET` request. That is not necessary, and the commit introducing this behaviour was a refactoring commit: 3558e6f Performance improvement here should be immaterial. Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
10 tasks
siavashs
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we spawned one
FileServerperGETrequest. That is not necessary, and the commit introducing this behaviour was a refactoring commit: 3558e6fStacked commit, see #5023
Pull Request Checklist
Please check all the applicable boxes.
benchstatto compare benchmarksWhich user-facing changes does this PR introduce?