Skip to content

Pin JMX Exporter compatibility test to a release once one ships the stable Metrics class #2179

@zeitlinger

Description

@zeitlinger

The JMX Exporter compatibility job (.github/workflows/jmx-exporter-compatibility.yml) currently tests jmx_exporter main instead of the latest release.

Why: the integration_test_suite only compiles against current client_java when jmx_exporter imports the stable io.prometheus.metrics.expositionformats.generated.Metrics class (added in #1873). The latest release, 1.5.0, instead imports the version-stamped ...generated.com_google_protobuf_4_32_0.Metrics directly, which breaks whenever we bump protobuf (currently 4.35.0). jmx_exporter main already adopted the stable class.

Action: once a jmx_exporter release ships that uses the stable Metrics class, switch the compatibility job back to pinning that release (restore DEFAULT_JMX_EXPORTER_VERSION as the default ref in .mise/lib/jmx_exporter_compat.py) for a deterministic, renovate-bumped target. DEFAULT_JMX_EXPORTER_VERSION in mise.toml stays renovate-tracked in the meantime so the target version is current when we switch.

Context: #2167 and dhoard's comment; follow-up PR #2178.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions