flake8 test passing #373
Merged
flake8 test passing #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tusharmakkar08
force-pushed
the
flake8-test-pass
branch
3 times, most recently
from
2250e13 to
bf24524
Compare
Author: tusharmakkar08 [tusharmakkar08@gmail.com] Signed-off-by: Tushar Makkar <tushar.makkar@vyom.com>
tusharmakkar08
force-pushed
the
flake8-test-pass
branch
from
bf24524 to
8114053
Compare
tusharmakkar08
force-pushed
the
flake8-test-pass
branch
from
3cfea1b to
3935c8f
Compare
|
Hey @brian-brazil Did the corresponding changes to make the PR compliant. Thanks. |
Author: tusharmakkar08 [tusharmakkar08@gmail.com] Signed-off-by: Tushar Makkar <tushar.makkar@vyom.com>
tusharmakkar08
force-pushed
the
flake8-test-pass
branch
from
3935c8f to
7827b97
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @brian-brazil
Earlier flake8 test were failing.
I have fixed the tests.
P.S: This is my first PR on this repo. Let me know if I have missed anything.
Thanks.