Skip to content

Add python_requires to help pip#529

Merged
brian-brazil merged 1 commit intoprometheus:masterfrom
hugovk:patch-1
Nov 19, 2020
Merged

Add python_requires to help pip#529
brian-brazil merged 1 commit intoprometheus:masterfrom
hugovk:patch-1

Conversation

@hugovk
Copy link
Copy Markdown
Contributor

@hugovk hugovk commented Mar 13, 2020

This helps modern pip know what version of this library to install for the user's running Python.

@brian-brazil
Copy link
Copy Markdown
Contributor

This is breaking on pypy3.

@hugovk
Copy link
Copy Markdown
Contributor Author

hugovk commented Mar 13, 2020

It's unrelated, master also fails in the same way:

@brian-brazil
Copy link
Copy Markdown
Contributor

It seems to have passed on the main repo: https://travis-ci.org/github/prometheus/client_python/builds/659047979

@hugovk
Copy link
Copy Markdown
Contributor Author

hugovk commented Mar 13, 2020

That was 8 days ago, please could you trigger a new build?

image

@brian-brazil
Copy link
Copy Markdown
Contributor

Hmm, I guess upstream broke something: https://travis-ci.org/github/prometheus/client_python/jobs/662250250

Signed-off-by: Hugo <hugovk@users.noreply.github.com>
Signed-off-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@brian-brazil brian-brazil merged commit bae17eb into prometheus:master Nov 19, 2020
@brian-brazil
Copy link
Copy Markdown
Contributor

Thanks!

@hugovk hugovk deleted the patch-1 branch November 19, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants