-
Notifications
You must be signed in to change notification settings - Fork 836
Add a twisted resource for exposing metrics via twisted.web. #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
prometheus_client/twisted.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output is already utf-8 encoded.
|
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're still reecnoding this here. Have you tested this on python3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I missed this when doing the changes. I've now tested it against python 3.4 and the tests pass.
Note: the tests (but not the code) need twisted trunk to run (the http client being used was just recently ported).
8f5e62f to
e425610
Compare
|
That looks good, can you squash your commits please? |
e425610 to
d771b38
Compare
|
Done. |
Add a twisted resource for exposing metrics via twisted.web.
|
Thanks! |
|
Uhh does this example code even work? Looking at this pull request further, it looks like this was pulled in, but a newer version (0.0.14) hasn't been published with these twisted changes. @brian-brazil Do you mind minting a new version with these twisted changes? |
|
I've got a number of releases to do. |
I'm not sure if this belongs as part of the client, or should be an external package that depends on this.