Add c-lightning exporter to exporters.md#1737
Merged
brian-brazil merged 1 commit intoprometheus:masterfrom Aug 28, 2020
Merged
Conversation
The exporter was already added to the port-reservations list, and exports a variety of metrics from the Lightning Network client. Signed-off-by: Christian Decker <decker.christian@gmail.com>
Contributor
|
Thanks! Some suggestions to improve your exporter: _total is a suffix for counters, it shouldn't be used with gauges. Some metrics like lightning_channel_in_msatoshi_offered also sound like they might be counters rather than gauges. Units are inconsistent, sometimes missing and conflicting with the help text. You should consistently use satoshis, and also include satoshi as the unit in all relevant metric names for clarity. id is a bit of a generic label, peer or peer_id would be clearer. |
Contributor
Author
|
Thanks for the review @brian-brazil and a huge thanks for the suggestions, we'll implement them asap 👍 |
beorn7
added
the
exporters and integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exporter was already added to the port-reservations list, and exports a variety of metrics from the Lightning Network client.