Skip to content

Conversation

@puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Dec 7, 2018

@brian-brazil can you please take a look? This adapter is already deployed at multiple locations in production today.

@brian-brazil
Copy link
Contributor

Can you add the DCO?

Looking at your code, note that there's no requirement that timeseries from Prometheus have an instance label which would result in an empty source - which I believe Wavefront will reject. Also, underscore is a valid character in Wavefront metrics names, so there's no need to sanitize it.

Signed-off-by: Pierre Tessier <puckpuck.com@gmail.com>
@puckpuck
Copy link
Contributor Author

puckpuck commented Dec 7, 2018

DCO done.

Empty source does not get rejected by Wavefront, it will get set to "unknown" if missing.
Wavefront's UI creates hierarchies from metrics based on the .. Converting a _ to a . of the metric name to take advantage of the UI benefits is this is the typical use case for Wavefront.

@brian-brazil brian-brazil merged commit 570cd23 into prometheus:master Dec 7, 2018
@brian-brazil
Copy link
Contributor

Thanks!

aylei pushed a commit to aylei/docs that referenced this pull request Oct 28, 2019
)

* tidb-in-kubernetes: Migrate aliyun terraform deployment doc to docs repo

* improve format and wording

* update wording and format

* fix wording

* fix wording

* fix wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants