Skip to content

Add TiPrometheus(Prometheus adapter for TiKV) #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brian-brazil merged 2 commits into from
Dec 10, 2018
Merged

Add TiPrometheus(Prometheus adapter for TiKV) #1235

brian-brazil merged 2 commits into from
Dec 10, 2018

Conversation

@70data
Copy link
Contributor

@70data 70data commented Dec 9, 2018 •
edited
Loading

Prometheus adapter for TiKV.
TiPrometheus support remote read and write.
TiKV is distributed transactional key-value database, originally created to complement TiDB.
I hope it solves the prometheus's storage problem.
I hope to provide a new idea for time series data storage.

tomwilkie
tomwilkie reviewed Dec 9, 2018
View reviewed changes
@tomwilkie
Copy link
Member

tomwilkie commented Dec 9, 2018

You need to add a DCO to the existing commit.

@70data
fix sortd
398b786 
Signed-off-by: 70data <70data@gmail.com>
@70data
Copy link
Contributor Author

70data commented Dec 9, 2018

Done.
Please check.
@tomwilkie

@aixeshunter
Copy link

aixeshunter commented Dec 10, 2018

Is there no unit test in https://github.com/bragfoo/TiPrometheus?
And no Dockerfile, Makefile there.
Could u please update them?

@70data
Copy link
Contributor Author

70data commented Dec 10, 2018 •
edited
Loading

It's only a first edition but it's ready for production.
This will be followed by development, optimization of performance and availability.
And provide unit test、benchmark report、dockerfile and CI/CD tools.
Because tikv is a dynamically scalable kv storage, Prometheus is given the potential for unlimited expansion.
I will continue to do it later.

@aixeshunter
Copy link

aixeshunter commented Dec 10, 2018

It's only a first edition but it's ready for production.
This will be followed by development, optimization of performance and availability.
And provide unit test、benchmark report、dockerfile and CI/CD tools.
Because tikv is a dynamically scalable kv storage, Prometheus is given the potential for unlimited expansion.
I will continue to do it later.

OK, thx

brian-brazil
brian-brazil reviewed Dec 10, 2018
View reviewed changes
content/docs/operating/integrations.md Outdated
* [OpenTSDB](https://github.com/prometheus/prometheus/tree/master/documentation/examples/remote_storage/remote_storage_adapter): write
* [PostgreSQL/TimescaleDB](https://github.com/timescale/prometheus-postgresql-adapter): read and write
* [SignalFx](https://github.com/signalfx/metricproxy#prometheus): write
* [TiPrometheus](https://github.com/bragfoo/TiPrometheus): read and write
Copy link
Contributor

@brian-brazil brian-brazil Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be TiKV

Copy link
Contributor Author

@70data 70data Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be TiKV

Recovered.

@70data
Update TiPrometheus to TiKV
3616113 
Signed-off-by: yuchang <yuchang@360.cn>
@brian-brazil brian-brazil merged commit f84b1df into prometheus:master Dec 10, 2018
@brian-brazil
Copy link
Contributor

brian-brazil commented Dec 10, 2018

Thanks!

@otisg otisg mentioned this pull request Dec 30, 2018
Open
aylei pushed a commit to aylei/docs that referenced this pull request Oct 28, 2019
@DanielZhangQD @yikeke
tidb-in-kubernetes: migrate aws terraform deployment doc to docs repo (…
b7ac231 
…prometheus#1235)

* tidb-in-kubernetes: Migrate aws terraform deployment doc to docs repo

* update format and code blocks

* Improve display

* fix note format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomwilkie tomwilkie tomwilkie left review comments

+1 more reviewer

@brian-brazil brian-brazil brian-brazil left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@70data @tomwilkie @aixeshunter @brian-brazil