Skip to content

[WIP]Add a training & support page#1604

Merged
juliusv merged 8 commits intoprometheus:masterfrom
celestehorgan:add-training-page
May 13, 2020
Merged

[WIP]Add a training & support page#1604
juliusv merged 8 commits intoprometheus:masterfrom
celestehorgan:add-training-page

Conversation

@celestehorgan
Copy link

Closes #1599.

Todo:

  • Finalize criteria (if any) around PR-ing to this page and let @celestehorgan know.

Signed-off-by: Celeste Horgan <celeste@cncf.io>
@celestehorgan
Copy link
Author

celestehorgan commented Apr 21, 2020

@juliusv

<h2>Training</h2>
<p>
These training resources are created and delivered independently
by members of the Prometheus project team. Note that these do operate for a fee. This list is provided in alphabetical order.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all independent of the project, even if some of the individuals involved happen to be on -team. We shouldn't be promoting any one course over any other.

I think we should only be providing plain links, as we presently do with the commercial support list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all independent of the project, even if some of the individuals involved happen to be on -team. We shouldn't be promoting any one course over any other.

Yeah, I would just say that it's third-party trainings that are not officially endorsed by the Prometheus project.

I think we should only be providing plain links, as we presently do with the commercial support list.

I don't mind this one either way, but I do like the company logo boxes in the Commercial Support section below at least.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brian-brazil @juliusv How about:

These training resources are created and delivered by independent third parties. They operate for a fee. This list is provided in alphabetical order.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all of them have a fee.

My concerns still stand - we shouldn't be promoting any one course over any other. In addition from a legal standpoint the Robust Perception training is not from me personally.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah true, the first one in the RP series is a free training.

My concerns still stand - we shouldn't be promoting any one course over any other.

I guess you mean getting rid of the statement that says that they're delivered by Prometheus team members? I think I agree... as long as people fulfill the requirements below for adding a course, we shouldn't be the judges here (too much potential for commercial conflict of interest).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, agreed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better, but the blurbs are still there. I don't want to have to police the wording of companies marketing content, as that's tricky from an impartiality standpoint. It'd also end up pretty bloated on the page. There should only be a list of organisation names.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I see. I misunderstood your comment. Check the latest commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The headlines are still there, it should only be the company names. Otherwise RP could request for example an entry for each of our 9 courses.

@juliusv
Copy link
Member

juliusv commented Apr 21, 2020

I like this overall!

Probably we should then remove the list in the Commercial Support section on the Community page, and instead link to this new page from there.

Signed-off-by: Celeste Horgan <celeste@cncf.io>
Celeste Horgan added 3 commits April 27, 2020 12:02
Signed-off-by: Celeste Horgan <celeste@cncf.io>
Signed-off-by: Celeste Horgan <celeste@cncf.io>
Signed-off-by: Celeste Horgan <celeste@cncf.io>
</div>

<div class="col-md-6 doc-content">
<!-- NOTE: WIP -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just not mention this, the standard is currently applied is that you send a PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we not give some expectations for those PRs so they arrive in better shape before the first review round?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't ask for e.g. linkedin pages though, this is proposing new requirements that I don't see a need for.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those requirements are pretty reasonable to add / include though. It doesn't have to be specifically LinkedIn of course, but that's also not how I read the wording.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the course is instructor led, you must provide credentials (a link to your LinkedIn profile or resume will suffice)

that is strongly suggested

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, it doesn't need to be LinkedIn. But asking for some form of background info about an instructor or individual consultant who wants to add themselves to our site makes sense, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle, but the practicalities are problematic. For example I'm not sure if the SaaS that RP uses for our training supports this.

I think this is something that should be at most guidance to vendors on how to have a good landing page, not anything we actually try to enforce.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, if it's reworded from a requirement to recommendation, that would also be fine with me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a case of trying to find a technical solution to a social problem, in effect lawyering a hypothetical issue into a possible blocker.

Prometheus tends to work as a consensus-based project in which there's acceptable uncertainty space to operate in. Listing an example is not mandating a requirement.
If we try to lawyer every corner case, we will not get anything done in sane time frames.
If we prevent any changes, there is no way to build up new operational guidelines.

And: If today we got a PR with a new company being listed, we would do some due diligence anyway. So there is both precedent and implicit consensus for having requirements and not just merging anything.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As presently written in this PR, these would be new hard requirements.

So there is both precedent and implicit consensus for having requirements and not just merging anything.

The precedent I've seen is that there is no bar - beyond someone asking to be listed. One of the current entries was added at a time when their website made no mention of that company providing Prometheus services.

If a PR looks weird I'll certainly double check with the author, but I won't reject it.

Signed-off-by: Celeste Horgan <celeste@cncf.io>
@juliusv
Copy link
Member

juliusv commented May 8, 2020

I see the marketing blurbs were now removed in the last commit. @brian-brazil is this good to merge now?

@brian-brazil
Copy link
Contributor

brian-brazil commented May 8, 2020

It still contains a blurb for RP, a course name for LF, and is still adding new hard requirements for listing that even several existing listings do not meet.

@juliusv
Copy link
Member

juliusv commented May 8, 2020

Ok, I would personally prefer to not be that pedantic about it, but in the interest of getting this merged without veto, @celestehorgan let's maybe minimalize it even further and just have company names + links for the courses, and remove the all requirements for now? I would still like to have something like that again later, but maybe then we can discuss that separately.

@celestehorgan
Copy link
Author

@juliusv That sounds like a good plan. I'll submit a new commit in an hour or so.

@juliusv
Copy link
Member

juliusv commented May 11, 2020

@celestehorgan Any updates on the last commit to remove the blurbs + requirements? Otherwise I'm also happy to make those last changes myself if you're ok with it.

Signed-off-by: Celeste Horgan <celeste@cncf.io>
@celestehorgan
Copy link
Author

@juliusv :( apologies for the delay, see the latest commit.

@juliusv
Copy link
Member

juliusv commented May 11, 2020

@celestehorgan Thanks! Ah, now the latest commit also removed the whole "Add a resource" section that is linked to at the top. I think that section is definitely good to keep starting from "To submit, open a pull request against...", only the new requirements were disputed.

Signed-off-by: Celeste Horgan <celeste@cncf.io>
@celestehorgan
Copy link
Author

Updated!

@juliusv
Copy link
Member

juliusv commented May 11, 2020

Thanks! I think this looks good now. @brian-brazil all ok?

<div class="panel panel-default">
<div class="panel-body">
<a href="https://training.robustperception.io/" target="_blank">
<h3>Learn how to Monitor with Prometheus</h3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a marketing blurb.

The only text we should have here is the organisation names.

@juliusv
Copy link
Member

juliusv commented May 13, 2020

Just in the interest of getting things done[tm], I'll merge this for now and send an immediate follow-up to remove the still-controversial items.

@juliusv juliusv merged commit 3625189 into prometheus:master May 13, 2020
juliusv added a commit that referenced this pull request May 13, 2020
I just wanted to remove the marketing blurbs as requested in
#1604, but while doing that I
noticed that the current HTML wasn't using Bootstrap validly (the only
valid children of rows are cols, not containers), so I changed that
around everywhere as well, and also fixed the footer, which wasn't
captured in its usual non-fluid container.

Signed-off-by: Julius Volz <julius.volz@gmail.com>
juliusv added a commit that referenced this pull request May 14, 2020
* Training & Support page fixups / remove marketing blurbs

I just wanted to remove the marketing blurbs as requested in
#1604, but while doing that I
noticed that the current HTML wasn't using Bootstrap validly (the only
valid children of rows are cols, not containers), so I changed that
around everywhere as well, and also fixed the footer, which wasn't
captured in its usual non-fluid container.

Signed-off-by: Julius Volz <julius.volz@gmail.com>

* Fix courses ordering

Signed-off-by: Julius Volz <julius.volz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a training page

5 participants