Merged
Conversation
Signed-off-by: David Igou <igou.david@gmail.com>
david-igou
force-pushed
the
add-bsbmp-exporter
branch
from
9fcaba6 to
5db285f
Compare
Contributor
|
Thanks! Some suggestions for the exporter: The mutex in Collect seems to be redundant, you're not keeping any state (which is good). Ratios should be exposed rather than percentages. It's redundant to expose pressure in two slightly different units, pascals are the more base one. I'd suggest failing the scrape rather than crashing the exporter if there's an error. |
beorn7
added
the
exporters and integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exporter is for several models of Bosch Sensortec environmental sensors. Tested on Raspberry Pi Zero and 4, but should also work on Banana and Orange Pi's (I plan on verifying this)
Feedback is welcome.