Replace cloudflare_exporter #1919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing exporter for Cloudflare uses the old API that has been turned down. The new version written by GitLab supports the Cloudflare GraphQL API. Signed-off-by: Ben Kochie <superq@gmail.com>
roidelapluie
approved these changes
Apr 7, 2021
Member
|
I think in the past @roidelapluie argued in favor of letting the removed listings know; did either do that? Else, LGTM. |
Member
Author
|
CC @wehkamp. I had not done that, sorry. The old exporter won't work as Cloudflare has removed the old API. |
beorn7
added
the
exporters and integrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing exporter for Cloudflare uses the old API that has been
turned down. The new version written by GitLab supports the Cloudflare
GraphQL API.
Signed-off-by: Ben Kochie superq@gmail.com