Skip to content

Add a design docs page#1961

Merged
RichiH merged 2 commits intoprometheus:masterfrom
roidelapluie:designdoc
Jun 16, 2021
Merged

Add a design docs page#1961
RichiH merged 2 commits intoprometheus:masterfrom
roidelapluie:designdoc

Conversation

@roidelapluie
Copy link
Copy Markdown
Member

Signed-off-by: Julien Pivotto roidelapluie@inuits.eu

@roidelapluie roidelapluie marked this pull request as draft May 28, 2021 22:49
@roidelapluie
Copy link
Copy Markdown
Member Author

I will add more design docs once we agree on the principle.

@RichiH
Copy link
Copy Markdown
Member

RichiH commented May 28, 2021 via email

@beorn7
Copy link
Copy Markdown
Member

beorn7 commented May 31, 2021

Looks great in general.

Do you want to fill in more design docs here right now? Or do that in later PRs?

@beorn7
Copy link
Copy Markdown
Member

beorn7 commented May 31, 2021

In case it's useful, here my brainstorm:

(This is not meant to be a complete list. ;)

@beorn7
Copy link
Copy Markdown
Member

beorn7 commented Jun 1, 2021

@codesome
Copy link
Copy Markdown
Member

codesome commented Jun 1, 2021

TSDB Head Improvements (status: implemented, at least partially, or all? paging @codesome ): https://docs.google.com/document/d/184urkLQnM7rqLmGvS66I15jU2pyPk_qwd8v_qDlXczo/edit# and https://docs.google.com/document/d/1pnEsxB0CDLOxQipGw_vhkJpoDZfZPs_KjqCriumDAXQ/edit

Only the m-mapping of "full" chunks is done among them. The idea about "partial chunks" is in-progress (the snapshot PR).

Plus, everything in that doc is not planned to be implemented (for example the number 5 in second doc about series and tombstones). And the doc might/will not be 100% in sync with what was finally implemented or being implemented.

@beorn7
Copy link
Copy Markdown
Member

beorn7 commented Jun 1, 2021

Thanks @codesome .

I guess a certain degree of "we did this differently after all" is inherent to most design docs. So I don't think we have to call that out explicitly (but perhaps it's worth mentioning in the preamble on this page?).

Copy link
Copy Markdown
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding all those links to the table.

I found a few syntax issues, see comments.

In different news: Are you aware that we can use markdown tables on the site? See https://github.com/prometheus/docs/blob/master/content/docs/practices/histograms.md .

Comment thread content/docs/introduction/design-doc.md Outdated
design document, or some documents are not listed, please open a [pull
request](https://github.com/prometheus/docs/) to add it to this list.

Design doc dot not always reflect exactly what has been implemented, and
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design doc dot not… → Design docs do not…

Comment thread content/docs/introduction/design-doc.md Outdated
<table>
<tr><th>Document</th><th>Initial date</th><th>Status</th><th>Pull requests</th></tr>
<tr><td><a href="https://github.com/prometheus/alertmanager/blob/master/doc/design/secure-cluster-traffic.md">Secure Alertmanager cluster traffic</a></td><td>2019-02-21</td><td>Approved</td><td><a href="https://github.com/prometheus/alertmanager/pull/2237">alertmanager#2237</a></td></tr>
<tr><td>TSDB Head Improvements (<a href="document 1">https://docs.google.com/document/d/184urkLQnM7rqLmGvS66I15jU2pyPk_qwd8v_qDlXczo/edit#heading=h.ow34omg0frla</a> - <a href="document 2">https://docs.google.com/document/d/1pnEsxB0CDLOxQipGw_vhkJpoDZfZPs_KjqCriumDAXQ/edit#heading=h.qsf5sgqoqemc</a>)</td><td>2019-12-09</td><td>Partially implemented</td><td></td></tr>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link text and URL are switched here. (URL needs to be the href and "document 1/2" needs to be the text content of the tag.)

Comment thread content/docs/introduction/design-doc.md Outdated
<tr><td><a href="https://docs.google.com/document/d/1uSbD3T2beM-iX4-Hp7V074bzBRiRNlqUdcWP6JTDQSs/edit">topk/bottomk aggregation over time</a></td><td>2020-09-30</td><td>Implemented</td><td><a href="https://github.com/prometheus/prometheus/pull/8121">#8121</a> <a href="https://github.com/prometheus/prometheus/pull/8425">#8425</a></td></tr>
<tr><td><a href="https://docs.google.com/document/d/1tVeuzjpU4-TiYPNWJXKmcyIuZF6A2tUq270RbBT5zho/edit">http_sd_configs</a></td><td>2021-02-26</td><td>Under review</td><td><a href="https://github.com/prometheus/prometheus/pull/8839">#8839</a></td></tr>
<tr><td><a href="https://docs.google.com/document/d/1vROky2aIw3kAllfi95gwDJy5P2DyWnCihsjPXGpLwwo/edit#">prometheus/client_java & micrometer</a></td><td>2021-02-26</td><td>Under review</td><td></td></tr>
<tr><td><a href="https://docs.google.com/document/d/1oEpjiWfTHF352NCAOGolwij3EIkrprCkdQmaQMpjg4M/edit"></a>First-class network monitoring support in the Prometheus & Grafana ecosystem</td><td>2021-02-25</td><td>Under review</td><td></td></tr>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The </a> has to be moved after the title.

@beorn7
Copy link
Copy Markdown
Member

beorn7 commented Jun 9, 2021

An now there is the goreleaser design doc.

List is growing quickly. I guess it makes sense to merge this rather sooner than later so that we all can iterate on it easily.

(But see my syntax remarks above. And my question if we can't just use markdown tables, which would avoid those syntax quirks altogether.)

@beorn7
Copy link
Copy Markdown
Member

beorn7 commented Jun 14, 2021

I guess we should also add a TODO entry for reconsidering extrapolation with range selectors (rate/increase/delta) AKA "the (x)rate controversy". At the dev summit 2020/2, we stated: "We want to rethink this from first principles. We will collect our research, thoughts, considerations, and results in 'Prometheus is not feature complete' and discuss at a future dev summit."

I think the topic deserves a fully fledged design doc. I guess we just hadn't developed the habit back then and thought, we could shove it in that existing "Prometheus is not feature complete" document.

@roidelapluie roidelapluie force-pushed the designdoc branch 2 times, most recently from 4f0dc48 to 1c97c20 Compare June 14, 2021 22:34
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
Copy link
Copy Markdown
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

I'd say, let's merge and iron out any other nits incrementally later.

Copy link
Copy Markdown
Member

@RichiH RichiH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits; looks good otherwise, thanks!

Comment thread content/docs/introduction/design-doc.md Outdated
design document, or some documents are not listed, please open a [pull
request](https://github.com/prometheus/docs/) to add it to this list.

Design doc do not always reflect exactly what has been implemented, and
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Design doc do not always reflect exactly what has been implemented, and
Design docs do not always reflect exactly what has been implemented, and

Comment thread content/docs/introduction/design-doc.md Outdated
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
@RichiH RichiH marked this pull request as ready for review June 16, 2021 12:34
@RichiH RichiH merged commit 0fc546b into prometheus:master Jun 16, 2021
@RichiH
Copy link
Copy Markdown
Member

RichiH commented Jun 16, 2021

Thanks!

@roidelapluie
Copy link
Copy Markdown
Member Author

Note: in my last push, I have used "unbreakable dashes" instead of "dashes" for the dated. It keeps them on the same line in the page, I think it renders better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants