Skip to content

Update overview.md#2061

Closed
sjnester wants to merge 1 commit intoprometheus:mainfrom
sjnester:patch-2
Closed

Update overview.md#2061
sjnester wants to merge 1 commit intoprometheus:mainfrom
sjnester:patch-2

Conversation

@sjnester
Copy link
Copy Markdown

@sjnester sjnester commented Nov 8, 2021

I found the first sentence in "### What are metrics ?" awkward especially the use of the word "mean". Since I tripped over it I thought it was only fair to propose a small edit.

I found the first sentence in "### What are metrics ?" awkward especially the use of the word "mean".  Since I tripped over it I thought it was only fair to propose a small edit.
@RichiH
Copy link
Copy Markdown
Member

RichiH commented Nov 16, 2021

Thanks! Can you please sign the DCO?

@sjnester
Copy link
Copy Markdown
Author

Thanks! Can you please sign the DCO?

Hi - I'm new at this - can you point me to where I need to sign? Thanks!

@tredondo
Copy link
Copy Markdown
Contributor

tredondo commented Apr 6, 2022

@sjnester: I've run into exactly the same issue with that sentence. My PR was also rejected.

I'm trying to persuade the devs here to make the contribution process easier, and DCO is the thorn in the side here. See #2118.

@SuperQ
Copy link
Copy Markdown
Member

SuperQ commented Apr 7, 2022

This needs a DCO sign-off. You can use git commit -s --amend to add it.

@RichiH
Copy link
Copy Markdown
Member

RichiH commented May 27, 2022

@jan--f
Copy link
Copy Markdown
Contributor

jan--f commented Feb 17, 2026

Hello from the bug scrub!

Apologies for the long wait. This text was reworked so I don't think this change is need any longer. Please raise another issue/PR if there anything else to fix.

@jan--f jan--f closed this Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants