Skip to content

Conversation

@nwanduka
Copy link
Contributor

@nwanduka nwanduka commented Sep 8, 2025

In this PR, I:

  • Created a posts/ subdirectory inside blog-post/.
  • Moved all existing blog post content files into posts/.

Signed-off-by: Victoria Nduka <ndukavictoria7@gmail.com>
@sysadmind
Copy link
Contributor

This breaks the build. I think there are some other pieces missing if we move all these files. For example, we are looking at the blog-posts/ directory in this helpers file - https://github.com/prometheus/docs/blob/main/src/blog-helpers.ts#L5

point blogPostsDir to blog-posts/posts to restore build


Signed-off-by: Victoria Nduka <122698422+nwanduka@users.noreply.github.com>
@nwanduka
Copy link
Contributor Author

nwanduka commented Sep 9, 2025

@sysadmind you're right. thanks for pointing it out.

Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysadmind
Copy link
Contributor

@juliusv you had the feedback on the previous PR, do you want to weigh in on this one?

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for challenging this, but what are the rationales? 🙈

The directory is called blog-posts. Now it will be blog-posts/posts. Is there a reason to duplicate posts naming here? Additionally blog-posts will not have any more files (other than README). Are we not making it harder to contribute blog posts with this change? 🤔 Maybe I miss context, do you mind @nwanduka to explain some long term plan for this change in this PR?

@juliusv
Copy link
Member

juliusv commented Sep 12, 2025

I guess it all goes back to the discussion I started at #2718 (comment) - I don't mind that much whether the blog post instructions file is in the root or in a blog-specific subdir, I just found it cleaner to not have it in the same directory as all the blog post files themselves, since that requires an explicit code-level exception and also makes the new file harder to find by a human if it's in the same dir as all the blog post content files.

But yeah, maybe just calling the first dir blog/... and the content dir blog/content or blog/posts would be even clearer. Or just keep the new blog instructions in the repo root, I don't mind much either way :)

import path from "path";
import matter from "gray-matter";

const blogPostsDir = "blog-posts";
Copy link
Member

@bwplotka bwplotka Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are doing this, let's also remove the filter from line 38 🙈

Also maybe blog/posts might be clearer (as @juliusv mentioned)

@bwplotka
Copy link
Member

bwplotka commented Sep 12, 2025

Ah got it, I didn't see the previous discussion on my fix.

Then let's remove the filter which seemed to be the main reason why we are moving files here (:

Sounds like we have two options here then (happy with both)

A) Change dirs, remove coding filter.

B) Do nothing (:

Thanks for helping @nwanduka!

@juliusv
Copy link
Member

juliusv commented Sep 12, 2025

Yeah, the previously introduced special-case filtering should be removed now. Then let's do option A I would say.

Signed-off-by: Victoria Nduka <ndukavictoria7@gmail.com>
@nwanduka
Copy link
Contributor Author

Thanks a lot everyone (@sysadmind @bwplotka @juliusv) for reviewing and leaving your feedback. I appreciate it. I've made the necessary changes (that's option A) and I think this PR is ready for a final review.

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bwplotka bwplotka merged commit eccea3a into prometheus:main Sep 14, 2025
5 checks passed
@nwanduka nwanduka deleted the blog-posts branch November 2, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants