Skip to content

Add wchan.#280

Merged
pgier merged 1 commit into
prometheus:masterfrom
PierreF:add-wchan
Apr 30, 2020
Merged

Add wchan.#280
pgier merged 1 commit into
prometheus:masterfrom
PierreF:add-wchan

Conversation

@PierreF

@PierreF PierreF commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

For ncabatoff/process-exporter#140, I'm going to submit a PR on process-exporter to use upstream procfs (this repository) instead of github.com/ncabatoff/procfs fork.

But Wchan method is required by process-exporter and not yet implemented on prometheus/procfs, the PR add the feature.

This is mostly a cherry-pick of e1a38cb from github.com/ncabatoff/procfs
authored by @ncabatoff.

Edit: I've just seen that I referenced the wrong issue on process-exporter, fixed it the number.

This is mostly a cherry-pick of e1a38cb from github.com/ncabatoff/process-exporter
authored by @ncabatoff

Signed-off-by: Pierre Fersing <pierre.fersing@bleemeo.com>
@PierreF

PierreF commented Apr 20, 2020

Copy link
Copy Markdown
Contributor Author

Anything missing on this PR ? Can I do something to help this PR to be merged ?

@discordianfish

Copy link
Copy Markdown
Member

No, we're just slow :)

@discordianfish discordianfish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, thanks!

@pgier pgier left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pgier
pgier merged commit ea64cd2 into prometheus:master Apr 30, 2020
remijouannet pushed a commit to remijouannet/procfs that referenced this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants