tsdb: make panic lock-release test OS agnostic - #19339
Merged
Merged
Conversation
JustDaile
requested review from
a team,
bwplotka,
codesome,
jesusvazquez and
krajorama
as code owners
August 5, 2026 17:24
JustDaile
force-pushed
the
osagnostictests
branch
2 times, most recently
from
August 5, 2026 18:07
32d3fc1 to
404b039
Compare
Signed-off-by: Daile Alimo <daile.alimo1991@hotmail.com>
JustDaile
force-pushed
the
osagnostictests
branch
from
August 5, 2026 18:09
404b039 to
bfbc9d9
Compare
JustDaile
changed the title
krajorama
reviewed
Aug 6, 2026
krajorama
left a comment
krajorama
left a comment
Member
There was a problem hiding this comment.
Thank for your interest in the project, I have some comments.
Signed-off-by: Daile Alimo <daile.alimo1991@hotmail.com>
JustDaile
force-pushed
the
osagnostictests
branch
from
August 8, 2026 12:26
c28906f to
fa3625c
Compare
Signed-off-by: Daile Alimo <daile.alimo1991@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old test forced a chunk write failure by removing the mmapped chunk directory which
will not work on Windows, as directories with open files cannot be deleted.
This change instead injects a rogue chunk segment with a higher sequence number,
causing the next chunk write to fail through the same code path in an OS-independent way.
This allows the test to run on Windows while exercising the same panic and lock-release behavior.