Refactor Infra, pkg/provider and GKE provider#413
Merged
geekodour merged 6 commits intoprometheus:masterfrom Jul 23, 2020
Merged
Refactor Infra, pkg/provider and GKE provider#413geekodour merged 6 commits intoprometheus:masterfrom
geekodour merged 6 commits intoprometheus:masterfrom
Conversation
* Made call to gke.NewGKEClient lazy * Add GKE.checkDeploymentVarsAndFiles to validate inputs * Remov GKE.setProjectID Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com>
* Add support for default DeploymentVars and DeploymentFiles * Update gke.New * Update infra to use provider.DeploymentResource Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com>
* Add test for provider.MergeDeploymentVars * Change provider.DefaultDeploymentResource to NewDeploymentResource * Add provider.MergeDeploymentVars * Separate FlagDeploymentVars and DefaultDeploymentVars Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com>
geekodour
changed the title
geekodour
commented
Jul 19, 2020
Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com>
geekodour
changed the title
Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com>
geekodour
commented
Jul 19, 2020
Contributor
krasi-georgiev
left a comment
krasi-georgiev
left a comment
There was a problem hiding this comment.
LGTM with some small nits
* Update SetupGKEDeploymentResources to SetupDeploymentResources * Minor refactorings to checkDeploymentVarsAndFiles Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com>
Contributor
Author
|
|
kushalShukla-web
pushed a commit
to kushalShukla-web/test-infra
that referenced
this pull request
Feb 8, 2025
* Made call to GKE.NewGKEClient lazy * Remove GKE.setProjectID and add Add GKE.checkDeploymentVarsAndFiles * Add provider.DeploymentResource with support for default DeploymentVars and FlagDeploymentVars * Add provider.MergeDeploymentVars and tests * Add GKE.SetupDeploymentResources which will allow provider specific DeploymentVars Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're on our way to add KIND support (#390) and EKS support (#384) for different test-infra components, it makes sense to allow the
DeploymentVarsto be variable among different providers aswell.This PR adds some minor refactoring and adds the support for
DeploymentVarsoverriding and addsDefaultDeploymentVarsaswell. So that theDefaultDeploymentVarscan be overridden by-v. This can also be easily extended to add support for provider specificDeploymentVars(#406)Here are the things that this PR adds:
gke.NewGKEClientbe called lazily insideinfraGKE.setProjectIDand addGKE.checkDeploymentVarsAndFilesto validate inputDeploymentVarsandDeploymentFilesprovider.DeploymentResourceprovider.MergeDeploymentVarsand tests which is basically the overriding ideaDeploymentVarsintoFlagDeploymentVarsandDefaultDeploymentVarsTodo:
cc : @rajdas98 @krasi-georgiev @nevill @weastel