Skip to content

Handle private repos counts not available to non-organization member#18

Merged
tboerger merged 3 commits into
promhippie:masterfrom
mafrosis:fix-private-repo-counts
Nov 17, 2020
Merged

Handle private repos counts not available to non-organization member#18
tboerger merged 3 commits into
promhippie:masterfrom
mafrosis:fix-private-repo-counts

Conversation

@mafrosis

Copy link
Copy Markdown
Contributor

When the GITHUB_EXPORTER_TOKEN is for a user who is not a member of a targeted organization, we get a crash 😄

@tboerger

Copy link
Copy Markdown
Member

Could you also add a changelog record to https://github.com/promhippie/github_exporter/tree/master/changelog/unreleased, please?

@mafrosis

Copy link
Copy Markdown
Contributor Author

Hi @tboerger - I thought about that, but then didn't do it 😄

We'll have merged conflicts after each merge, so I'll keep an eye on the merges coming through and force push each PR

@tboerger

Copy link
Copy Markdown
Member

You just need to write a markdown file per PR with https://github.com/promhippie/github_exporter/blob/master/changelog/TEMPLATE as a template, write it to https://github.com/promhippie/github_exporter/tree/master/changelog/unreleased and it will generate the changelog without any conflict after merging the PR ;)

@mafrosis

Copy link
Copy Markdown
Contributor Author

Looks like your Dockerhub pull limit may have been reached!

@mafrosis

Copy link
Copy Markdown
Contributor Author

Pushed an updated commit with the TEMPLATE file updated. I think this is what you want 😄

@tboerger

Copy link
Copy Markdown
Member

Not exactly what I mean :D

cp changelog/TEMPLATE changelog/unreleased/private-repo-count.md

instead of changing the template.

@mafrosis

Copy link
Copy Markdown
Contributor Author

Ready for merge now

@mafrosis

Copy link
Copy Markdown
Contributor Author

This calens needs some documentation it seems 😄

@tboerger

Copy link
Copy Markdown
Member

Yes, looks like I got to extend the README for the changelog a little bit, but anyway thanks for your efforts!

@mafrosis

Copy link
Copy Markdown
Contributor Author

At least the code had no apparent issues!

@tboerger tboerger merged commit beafb3a into promhippie:master Nov 17, 2020
@mafrosis mafrosis deleted the fix-private-repo-counts branch November 17, 2020 08:04
@tboerger

Copy link
Copy Markdown
Member

After finishing https://cloud.drone.io/promhippie/github_exporter/44 you could give the latest Docker tag a try, if everything behaves fine I will release v1.0.0.

@tboerger tboerger added the bug Something isn't working label Nov 17, 2020
@tboerger tboerger added this to the v1.0.0 milestone Nov 17, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants