Fix some bug risks and code quality issues

.deepsource.toml

@@ -0,0 +1,18 @@
+version = 1
+
+test_patterns = [
+  "tests/**"
+]
+
+exclude_patterns = [
+  "tools/**",
+  "examples/**",
+  "docs/**"
+]
+
+[[analyzers]]
+name = "python"
+enabled = true
+
+  [analyzers.meta]
+  runtime_version = "3.x.x"

prompt_toolkit/contrib/telnet/server.py

@@ -13,7 +13,7 @@
 from prompt_toolkit.formatted_text import AnyFormattedText, to_formatted_text
 from prompt_toolkit.input.posix_pipe import PosixPipeInput
 from prompt_toolkit.output.vt100 import Vt100_Output
-from prompt_toolkit.renderer import print_formatted_text as print_formatted_text
+from prompt_toolkit.renderer import print_formatted_text
 from prompt_toolkit.styles import BaseStyle, DummyStyle
 
 from .log import logger

prompt_toolkit/key_binding/key_bindings.py

@@ -346,7 +346,7 @@ def get() -> List[Binding]:
                     any_count = 0
 
                     for i, j in zip(b.keys, keys):
-                        if i != j and i != Keys.Any:
+                        if i not in (j, Keys.Any):
                             match = False
                             break
 
@@ -379,7 +379,7 @@ def get() -> List[Binding]:
                 if len(keys) < len(b.keys):
                     match = True
                     for i, j in zip(b.keys, keys):
-                        if i != j and i != Keys.Any:
+                        if i not in (j, Keys.Any):
                             match = False
                             break
                     if match:

prompt_toolkit/layout/processors.py

@@ -636,7 +636,7 @@ def apply_transformation(self, ti: TransformationInput) -> Transformation:
             t = (self.style, self.get_char())
             fragments = explode_text_fragments(fragments)
 
-            for i in range(len(fragments)):
+            for i, _ in enumerate(fragments):
                 if fragments[i][1] == " ":
                     fragments[i] = t
                 else:

prompt_toolkit/output/win32.py

@@ -151,12 +151,10 @@ def _winapi(self, func, *a, **kw):
         if _DEBUG_RENDER_OUTPUT:
             self.LOG.write(("%r" % func.__name__).encode("utf-8") + b"\n")
             self.LOG.write(
-                b"     " + ", ".join(["%r" % i for i in a]).encode("utf-8") + b"\n"
+                b"     " + ", ".join("%r" % i for i in a).encode("utf-8") + b"\n"
             )
             self.LOG.write(
-                b"     "
-                + ", ".join(["%r" % type(i) for i in a]).encode("utf-8")
-                + b"\n"
+                b"     " + ", ".join("%r" % type(i) for i in a).encode("utf-8") + b"\n"
             )
             self.LOG.flush()
 

prompt_toolkit/widgets/base.py

@@ -747,7 +747,7 @@ def mouse_handler(mouse_event: MouseEvent) -> None:
             result.append(("", "\n"))
 
         # Add mouse handler to all fragments.
-        for i in range(len(result)):
+        for i, _ in enumerate(result):
             result[i] = (result[i][0], result[i][1], mouse_handler)
 
         result.pop()  # Remove last newline.