Fix ValueError: I/O operation on closed file #1457
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanslenders
force-pushed
the
fix-valueerror-io-operation-on-closed-file
branch
from
cd2b153 to
5382699
Compare
jonathanslenders
changed the title
This was referenced Jul 8, 2021
|
Maybe not needed anymore. Fixed here: prompt-toolkit/ptpython#466 |
Bugfix for ptpython/Xonsh. This handles the situation where `sys.stdin` gets closed, by running for instance `sys.stdin.close()`.
jonathanslenders
force-pushed
the
fix-valueerror-io-operation-on-closed-file
branch
from
5382699 to
5b8c5e9
Compare
Bubobubobubobubo
added a commit
to Bubobubobubobubo/sardine
that referenced
this pull request
Aug 28, 2022
This integration is not perfect. I had to read the configuration file and ended up duplication some classes and functions from `sardine` to `fishery` in order to do it. There is a nasty bug that shows up when quitting from the experimental editor. This issue is already documented by `ptpython` and should have been fixed already if I am to believe GitHub issues: prompt-toolkit/python-prompt-toolkit#1457. This is probably worth reporting to the maintainers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.