Skip to content

Don't attempt to handle SIGINT on Windows. #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Don't attempt to handle SIGINT on Windows. #1554

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion prompt_toolkit/application/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@
)
from prompt_toolkit.utils import Event, in_main_thread

from ..utils import is_windows
from .current import get_app_session, set_app
from .run_in_terminal import in_terminal, run_in_terminal

Expand Down Expand Up @@ -659,8 +660,11 @@ async def run_async(
"""
assert not self._is_running, "Application is already running."

if not in_main_thread():
if not in_main_thread() or is_windows():
# Handling signals in other threads is not supported.
# Also on Windows, `add_signal_handler(signal.SIGINT, ...)` raises
# `NotImplementedError`.
# See: https://github.com/prompt-toolkit/python-prompt-toolkit/issues/1553
handle_sigint = False

async def _run_async() -> _AppResult:
Expand Down